Throw exceptions when attempts are made to use localStorage in packaged apps.

Throw exceptions when attempts are made to use localStorage in packaged apps.

BUG=130224
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152232

[dharcourt, 2012-08-17 00:19:07]

The fix for http://code.google.com/p/chromium/issues/detail?id=130224 ("Warn on
localStorage Use") is available for review.

Changes involved adding a stub to throw an exception when window.localStorage is
accessed and making a corresponding change to the test that verified that
localStorage is not accessible in apps.

Thanks for the review!

    - Charles

[Mihai Parparita -not on Chrome, 2012-08-17 22:41:25]

LGTM

BTW, the TEST= line in the CL description is meant for the QA, in case there is
manual testing that needs to be done to validate a changelist. If your change is
covered by automated tests (like it is in this case), then it can be omitted.
See
http://dev.chromium.org/developers/contributing-code#TOC-Create-a-change-list...
for more details.

http://codereview.chromium.org/10832352/diff/2001/chrome/test/data/extensions...
File chrome/test/data/extensions/platform_apps/storage/test.js (right):

http://codereview.chromium.org/10832352/diff/2001/chrome/test/data/extensions...
chrome/test/data/extensions/platform_apps/storage/test.js:22:
chrome.test.assertTrue(!window.localStorage);
The chrome.test.assertTrue call seems unnecessary, since you don't expect it to
happen (if the exception gets thrown when the property is accessed).

[dharcourt, 2012-08-17 22:55:42]

Thanks for the review. I removed the unnecessary assert in the test and "TEST="
in the description.

   - Charles

http://codereview.chromium.org/10832352/diff/2001/chrome/test/data/extensions...
File chrome/test/data/extensions/platform_apps/storage/test.js (right):

http://codereview.chromium.org/10832352/diff/2001/chrome/test/data/extensions...
chrome/test/data/extensions/platform_apps/storage/test.js:22:
chrome.test.assertTrue(!window.localStorage);
Thanks, I removed the chrome.test.assertTrue.

[commit-bot: I haz the power, 2012-08-18 00:49:33]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dharcourt@chromium.org/10832352/6001

[commit-bot: I haz the power, 2012-08-18 03:11:27]

Change committed as 152232