Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Issue 10832342: Rename "global context" to "native context", (Closed)

Created:
8 years, 4 months ago by rossberg
Modified:
8 years, 4 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Visibility:
Public.

Description

Rename "global context" to "native context", in anticipation of the upcoming lexical global scope. Mostly automatised as: for FILE in `egrep -ril "global[ _]?context" src test/cctest` do echo $FILE sed "s/Global context/Native context/g" <$FILE >$FILE.0 sed "s/global context/native context/g" <$FILE.0 >$FILE.1 sed "s/global_context/native_context/g" <$FILE.1 >$FILE.2 sed "s/GLOBAL_CONTEXT/NATIVE_CONTEXT/g" <$FILE.2 >$FILE.3 sed "s/GlobalContext/NativeContext/g" <$FILE.3 >$FILE rm $FILE.[0-9] done R=mstarzinger@chromium.org BUG= TEST= Committed: https://code.google.com/p/v8/source/detail?r=12325

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+697 lines, -696 lines) Patch
M src/accessors.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/api.cc View 7 chunks +9 lines, -9 lines 0 comments Download
M src/arm/builtins-arm.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M src/arm/deoptimizer-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm/full-codegen-arm.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M src/arm/stub-cache-arm.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 53 chunks +112 lines, -112 lines 0 comments Download
M src/builtins.cc View 9 chunks +15 lines, -15 lines 0 comments Download
M src/compilation-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.cc View 5 chunks +10 lines, -10 lines 0 comments Download
M src/contexts.h View 7 chunks +19 lines, -18 lines 2 comments Download
M src/contexts.cc View 10 chunks +16 lines, -16 lines 0 comments Download
M src/debug.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/debug-debugger.js View 1 chunk +1 line, -1 line 0 comments Download
M src/deoptimizer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/execution.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M src/factory.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/factory.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M src/flag-definitions.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/handles.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap.h View 5 chunks +10 lines, -10 lines 2 comments Download
M src/heap.cc View 17 chunks +28 lines, -28 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M src/ia32/deoptimizer-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 6 chunks +7 lines, -7 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 4 chunks +14 lines, -14 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/incremental-marking.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M src/isolate.h View 5 chunks +15 lines, -15 lines 0 comments Download
M src/isolate.cc View 4 chunks +11 lines, -11 lines 0 comments Download
M src/json-parser.h View 1 chunk +1 line, -1 line 0 comments Download
M src/liveobjectlist.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/mark-compact.cc View 6 chunks +15 lines, -15 lines 0 comments Download
M src/mips/builtins-mips.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M src/mips/deoptimizer-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/objects.h View 9 chunks +14 lines, -14 lines 0 comments Download
M src/objects.cc View 16 chunks +42 lines, -42 lines 0 comments Download
M src/objects-inl.h View 7 chunks +12 lines, -12 lines 0 comments Download
M src/objects-printer.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/objects-visiting.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/objects-visiting-inl.h View 4 chunks +4 lines, -4 lines 0 comments Download
M src/profile-generator.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M src/runtime.cc View 32 chunks +51 lines, -51 lines 0 comments Download
M src/scopes.h View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/serialize.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/string-stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/stub-cache.h View 1 chunk +1 line, -1 line 0 comments Download
M src/stub-cache.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/type-info.h View 3 chunks +4 lines, -4 lines 0 comments Download
M src/type-info.cc View 12 chunks +22 lines, -22 lines 0 comments Download
M src/v8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M src/x64/deoptimizer-x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 5 chunks +13 lines, -13 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-api.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-compiler.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-debug.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-heap.cc View 17 chunks +26 lines, -26 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M test/cctest/test-serialize.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
rossberg
8 years, 4 months ago (2012-08-16 14:38:37 UTC) #1
Michael Starzinger
LGTM (with two nits). Mostly rubber-stamped, just made some spot checks. You are so lucky ...
8 years, 4 months ago (2012-08-16 16:33:56 UTC) #2
rossberg
On 2012/08/16 16:33:56, Michael Starzinger wrote: > LGTM (with two nits). Mostly rubber-stamped, just made ...
8 years, 4 months ago (2012-08-17 08:40:24 UTC) #3
rossberg
8 years, 4 months ago (2012-08-17 08:40:32 UTC) #4
https://chromiumcodereview.appspot.com/10832342/diff/1/src/contexts.h
File src/contexts.h (right):

https://chromiumcodereview.appspot.com/10832342/diff/1/src/contexts.h#newcode417
src/contexts.h:417: static const int kSize =
On 2012/08/16 16:33:56, Michael Starzinger wrote:
> Should still fit into one line.

Done.

https://chromiumcodereview.appspot.com/10832342/diff/1/src/heap.h
File src/heap.h (right):

https://chromiumcodereview.appspot.com/10832342/diff/1/src/heap.h#newcode67
src/heap.h:67: V(Map, native_context_map, NativeContextMap)                     
         \
On 2012/08/16 16:33:56, Michael Starzinger wrote:
> Add a few spaces to make the '\'es align.

Done.

Powered by Google App Engine
This is Rietveld 408576698