Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 10832340: Send NOTIFICATION_WALLPAPER_ANIMATION_FINISHED for solid background (Closed)

Created:
8 years, 4 months ago by Dmitry Polukhin
Modified:
8 years, 4 months ago
Reviewers:
bshe
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Send NOTIFICATION_WALLPAPER_ANIMATION_FINISHED for solid background BUG=143346 TEST=set index of wallpaper image to -2 in Local State and run chrome with --login_manager Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152079

Patch Set 1 #

Total comments: 2

Patch Set 2 : added OWNERS #

Patch Set 3 : one more OWNERS file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
A ash/desktop_background/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ash/desktop_background/desktop_background_controller.cc View 2 chunks +10 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/background/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Dmitry Polukhin
8 years, 4 months ago (2012-08-16 10:38:22 UTC) #1
bshe
lgtm you may want to add owners https://chromiumcodereview.appspot.com/10832340/diff/1/ash/desktop_background/desktop_background_controller.h File ash/desktop_background/desktop_background_controller.h (right): https://chromiumcodereview.appspot.com/10832340/diff/1/ash/desktop_background/desktop_background_controller.h#newcode156 ash/desktop_background/desktop_background_controller.h:156: // Send ...
8 years, 4 months ago (2012-08-16 16:13:18 UTC) #2
Dmitry Polukhin
Added OWNERS file. https://chromiumcodereview.appspot.com/10832340/diff/1/ash/desktop_background/desktop_background_controller.h File ash/desktop_background/desktop_background_controller.h (right): https://chromiumcodereview.appspot.com/10832340/diff/1/ash/desktop_background/desktop_background_controller.h#newcode156 ash/desktop_background/desktop_background_controller.h:156: // Send notification that background animation ...
8 years, 4 months ago (2012-08-16 17:18:32 UTC) #3
bshe
On 2012/08/16 17:18:32, Dmitry Polukhin wrote: > Added OWNERS file. > > https://chromiumcodereview.appspot.com/10832340/diff/1/ash/desktop_background/desktop_background_controller.h > File ...
8 years, 4 months ago (2012-08-16 22:45:01 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-17 07:20:33 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698