Issue 10832336: chromeos: Use gfx::ImageSkia instead of SkBitmap for downloaded profile image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832336: chromeos: Use gfx::ImageSkia instead of SkBitmap for downloaded profile image. (Closed)

Created:
8 years, 4 months ago by sadrul

Modified:
8 years, 4 months ago

Reviewers:
Ivan Korotkov

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

chromeos: Use gfx::ImageSkia instead of SkBitmap for downloaded profile image. BUG=141146 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151895

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -12 lines)			Patch
M	chrome/browser/chromeos/login/mock_user_manager.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/user_manager.h	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.h	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/user_manager_impl.cc	View	1	4 chunks	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ivan Korotkov

LGTM Please make sure that: *) adding a user and selecting profile picture works; *) ...

8 years, 4 months ago (2012-08-16 08:37:43 UTC) #2

sadrul

8 years, 4 months ago (2012-08-16 15:12:07 UTC) #3

Tested both cases; seems to be working OK. Thanks!

http://codereview.chromium.org/10832336/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/user_manager_impl.cc (right):

http://codereview.chromium.org/10832336/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/user_manager_impl.cc:1270: // TODO(ivankr):
temporary measure until UserManager is fully migrated
On 2012/08/16 08:37:43, Ivan Korotkov wrote:
> Please remove TODO and temp variable.

Done.

Expand Messages | Collapse Messages