Issue 10832335: WebSocket over SPDY: update test data and expectation

Issue 10832335: WebSocket over SPDY: update test data and expectation (Closed)

Created:
8 years, 4 months ago by Takashi Toyoshima

Modified:
8 years, 4 months ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

WebSocket over SPDY: unit test cleanup To prepare for new framing implementation and tests. - update test data to mimic real cases and follow the latest spec - reorganize utility functions for tests BUG=42320 TEST=net_unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152484

Patch Set 1 #

Patch Set 2 : with spdy3 #

Patch Set 3 : spdy2 #

Patch Set 4 : ready for review #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+219 lines, -257 lines)			Patch
M	net/spdy/spdy_stream_spdy2_unittest.cc	View	1 2	3 chunks	+3 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_stream_spdy3_unittest.cc	View	1 2 3	3 chunks	+3 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_test_util_spdy2.h	View	1 2	3 chunks	+0 lines, -17 lines	0 comments	Download
M	net/spdy/spdy_test_util_spdy2.cc	View	1 2	3 chunks	+0 lines, -71 lines	0 comments	Download
M	net/spdy/spdy_test_util_spdy3.h	View	1 2 3	3 chunks	+0 lines, -17 lines	0 comments	Download
M	net/spdy/spdy_test_util_spdy3.cc	View	1 2 3	3 chunks	+0 lines, -71 lines	0 comments	Download
M	net/spdy/spdy_websocket_stream_spdy2_unittest.cc	View	1 2	5 chunks	+18 lines, -30 lines	0 comments	Download
M	net/spdy/spdy_websocket_stream_spdy3_unittest.cc	View	1 2 3	5 chunks	+19 lines, -31 lines	0 comments	Download
M	net/spdy/spdy_websocket_test_util_spdy2.h	View	1 2	1 chunk	+23 lines, -8 lines	0 comments	Download
M	net/spdy/spdy_websocket_test_util_spdy2.cc	View	1 2	2 chunks	+65 lines, -0 lines	0 comments	Download
M	net/spdy/spdy_websocket_test_util_spdy3.h	View	1 2 3	1 chunk	+23 lines, -8 lines	0 comments	Download
M	net/spdy/spdy_websocket_test_util_spdy3.cc	View	1 2 3	2 chunks	+65 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Takashi Toyoshima

Hi Ryan, Could you look this change. I'm rebasing the change to support new WebSocket ...

8 years, 4 months ago (2012-08-16 07:49:31 UTC) #1

Ryan Hamilton

LGTM. Sorry for the delay. I was OOO Thursday and Friday.

8 years, 4 months ago (2012-08-20 16:53:48 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/10832335/2017

8 years, 4 months ago (2012-08-21 00:09:26 UTC) #3

Change committed as 152484

Expand Messages | Collapse Messages