Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 10832299: Extensions Docs Server: Fix preview.py (Closed)

Created:
8 years, 4 months ago by cduvall
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Extensions Docs Server: Fix preview.py The preview server now imports fakes like integration_test. This works for all pages except for the apps samples, but that requires a larger fix than this. BUG=142530 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151594 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151651

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : fix for .svn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M chrome/common/extensions/docs/server2/fake_fetchers.py View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
cduvall
Preview server is fixed.
8 years, 4 months ago (2012-08-14 17:23:37 UTC) #1
not at google - send to devlin
fake_fetchers needs a file-level comment, but otherwise lgtm.
8 years, 4 months ago (2012-08-14 22:35:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/10832299/1004
8 years, 4 months ago (2012-08-14 23:10:17 UTC) #3
commit-bot: I haz the power
Try job failure for 10832299-1004 (retry) on linux_chromeos for step "browser_tests". It's a second try, ...
8 years, 4 months ago (2012-08-15 02:51:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cduvall@chromium.org/10832299/1004
8 years, 4 months ago (2012-08-15 02:51:44 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 04:22:10 UTC) #6
Change committed as 151651

Powered by Google App Engine
This is Rietveld 408576698