Remove the dependency on the STRIP env variable for Android

Remove the dependency on the STRIP env variable for Android

Android builds currently rely on the STRIP environment variable to be available
during build time, rather than just at project generation time. It shouldn't.

BUG=142642
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151886

[Peter Beverloo, 2012-08-14 16:06:59]

I'm not entirely satisfied with the naming of "strip-binary", thus am open to
suggestions there.

[Torne, 2012-08-14 16:09:33]

https://chromiumcodereview.appspot.com/10832295/diff/1/build/android/envsetup...
File build/android/envsetup_functions.sh (right):

https://chromiumcodereview.appspot.com/10832295/diff/1/build/android/envsetup...
build/android/envsetup_functions.sh:195: DEFINES+=" android_strip=${STRIP}"
Can't we derive this from android_toolchain inside the gyp files, rather than
passing it in? I'd prefer if we pass the smallest possible set of environment
variables here.

[Peter Beverloo, 2012-08-15 13:59:21]

On 2012/08/14 16:09:33, Torne 
> Can't we derive this from android_toolchain inside the gyp files, rather than
> passing it in? I'd prefer if we pass the smallest possible set of environment
> variables here.

Done. Thank you!

[Torne, 2012-08-15 14:42:00]

lgtm

[Peter Beverloo, 2012-08-15 15:06:03]

Thanks!

+yfriedman for tools/android/
+jam for content/ (one-line Android specific gyp change, could TBR).

[nilesh, 2012-08-15 15:54:51]

LGTM

On 2012/08/15 15:06:03, Peter Beverloo wrote:
> Thanks!
> 
> +yfriedman for tools/android/
> +jam for content/ (one-line Android specific gyp change, could TBR).

[Yaron, 2012-08-15 18:15:04]

lgtm

[jam, 2012-08-15 21:28:55]

lgtm

[commit-bot: I haz the power, 2012-08-16 10:33:36]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/peter@chromium.org/10832295/7003

[commit-bot: I haz the power, 2012-08-16 13:52:07]

Change committed as 151886