Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(747)

Issue 10832293: Fixing a crash when loading themes on Win8. (Closed)

Created:
8 years, 4 months ago by MAD
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Fixing a crash when loading themes on Win8. Some structures have new fields, so we must make sure to zero them all upon initialization. Actually simple/safe enough for tbr... TBR=bryner@chromium.org BUG=141464 TEST=Make sure we can install a theme without crashing while running in Metro mode. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151511

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/safe_browsing/signature_util_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
MAD
Et voilĂ ! :-)
8 years, 4 months ago (2012-08-14 15:43:08 UTC) #1
Ryan Sleevi
lgtm
8 years, 4 months ago (2012-08-14 15:46:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/10832293/1
8 years, 4 months ago (2012-08-14 15:47:08 UTC) #3
commit-bot: I haz the power
Presubmit check for 10832293-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-14 15:47:10 UTC) #4
MAD
OWNER's approval please? Thanks! BYE MAD...
8 years, 4 months ago (2012-08-14 15:50:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mad@chromium.org/10832293/1
8 years, 4 months ago (2012-08-14 15:51:58 UTC) #6
Brian Ryner
lgtm
8 years, 4 months ago (2012-08-14 16:20:47 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 18:10:27 UTC) #8
Change committed as 151511

Powered by Google App Engine
This is Rietveld 408576698