Reduce space used for stackmaps.

runtime/vm/object.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_OBJECT_H_
 #define VM_OBJECT_H_
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "platform/utils.h"
@@ skipping 2322 matching lines @@
 
   RawCode* GetCode() const { return raw_ptr()->code_; }
   void SetCode(const Code& code) const;
 
   // Return the index of the highest stack slot that has an object.
   intptr_t MaximumBitIndex() const { return raw_ptr()->max_set_bit_index_; }
 
   // Return the index of the lowest stack slot that has an object.
   intptr_t MinimumBitIndex() const { return raw_ptr()->min_set_bit_index_; }
 
-  static const intptr_t kBytesPerElement = kWordSize;
-  static const intptr_t kMaxElements = kSmiMax / kBytesPerElement;
+  static const intptr_t kMaxLengthInBytes = kSmiMax;
 
   static intptr_t InstanceSize() {
     ASSERT(sizeof(RawStackmap) == OFFSET_OF(RawStackmap, data_));
     return 0;
   }
-  static intptr_t InstanceSize(intptr_t len) {

[Kevin Millikin (Google), 2012/08/14 13:02:32]

This was already a length in bytes, no need to multiply by kBytesPerElement.

(Bytes per element is really 1/8 because the elements are bits.  Better to get
rid of the concept of element in stackmaps.)

-    ASSERT(0 <= len && len <= kMaxElements);
-    return RoundedAllocationSize(
-        sizeof(RawStackmap) + (len * kBytesPerElement));
+  static intptr_t InstanceSize(intptr_t length_in_bytes) {

[Vyacheslav Egorov (Google), 2012/08/15 14:17:37]

I wonder if we can pass a real length here to align with e.g.
Array::InstanceSize.

[Kevin Millikin (Google), 2012/08/15 14:41:31]

Yes.  Will do with the next change.

+    ASSERT(length_in_bytes >= 0);
+    ASSERT(length_in_bytes <= kMaxLengthInBytes);
+    return RoundedAllocationSize(sizeof(RawStackmap) + length_in_bytes);
   }
-  static RawStackmap* New(uword pc, BitmapBuilder* bmap);
+  static RawStackmap* New(intptr_t pc_offset,
+                          intptr_t length_in_bits,
+                          BitmapBuilder* bmap);
 
  private:
   inline intptr_t SizeInBits() const;
 
   void SetMinBitIndex(intptr_t value) const {
     raw_ptr()->min_set_bit_index_ = value;
   }
   void SetMaxBitIndex(intptr_t value) const {
     raw_ptr()->max_set_bit_index_ = value;
   }
@@ skipping 3120 matching lines @@
     if (this->CharAt(i) != str.CharAt(begin_index + i)) {
       return false;
     }
   }
   return true;
 }
 
 }  // namespace dart
 
 #endif  // VM_OBJECT_H_