Reduce space used for stackmaps.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
@@ skipping 6835 matching lines @@
   uint8_t byte_mask = 1U << bit_remainder;
   uint8_t* byte_addr = &(raw_ptr()->data_[byte_index]);
   if (value) {
     *byte_addr |= byte_mask;
   } else {
     *byte_addr &= ~byte_mask;
   }
 }
 
 
-RawStackmap* Stackmap::New(uword pc_offset, BitmapBuilder* bmap) {
+RawStackmap* Stackmap::New(intptr_t pc_offset,
+                           intptr_t length_in_bits,
+                           BitmapBuilder* bmap) {
   ASSERT(Object::stackmap_class() != Class::null());
   ASSERT(bmap != NULL);
   Stackmap& result = Stackmap::Handle();
-  intptr_t size = bmap->SizeInBytes();

[Kevin Millikin (Google), 2012/08/14 13:02:32]

Here we need to use the number of bytes covered by the stackmap, not the number
of bytes covered by the BitmapBuilder backing store (which is overallocated,
sometimes by a lot).

-  if (size < 0 || size > kMaxElements) {
+  intptr_t length_in_bytes =
+      Utils::RoundUp(length_in_bits, kBitsPerByte) / kBitsPerByte;
+  if (length_in_bytes < 0 || length_in_bytes > kMaxLengthInBytes) {
     // This should be caught before we reach here.
-    FATAL1("Fatal error in PcDescriptors::New: invalid size %ld\n", size);
+    FATAL1("Fatal error in Stackmap::New: invalid length %" PRIdPTR "\n",
+           length_in_bytes);
   }
   {
     // Stackmap data objects are associated with a code object, allocate them
     // in old generation.
     RawObject* raw = Object::Allocate(Stackmap::kClassId,
-                                      Stackmap::InstanceSize(size),
+                                      Stackmap::InstanceSize(length_in_bytes),
                                       Heap::kOld);
     NoGCScope no_gc;
     result ^= raw;
-    result.set_bitmap_size_in_bytes(size);
+    result.set_bitmap_size_in_bytes(length_in_bytes);

[Vyacheslav Egorov (Google), 2012/08/15 14:17:37]

I would prefer store length in bits here.

[Kevin Millikin (Google), 2012/08/15 14:41:31]

That is part of the next change.

   }
+  // When constructing a stackmap we store the pc offset in the stackmap's
+  // PC. StackmapTableBuilder::FinalizeStackmaps will replace it with the pc
+  // address.
+  ASSERT(pc_offset >= 0);
   result.SetPC(pc_offset);
-  intptr_t bound = bmap->SizeInBits();
-  for (intptr_t i = 0; i < bound; i++) {
+  for (intptr_t i = 0; i < length_in_bits; i++) {
     result.SetBit(i, bmap->Get(i));
   }
+  ASSERT(bmap->Maximum() < length_in_bits);
   result.SetMinBitIndex(bmap->Minimum());
   result.SetMaxBitIndex(bmap->Maximum());
   return result.raw();
 }
 
 
 void Stackmap::set_bitmap_size_in_bytes(intptr_t value) const {
   // This is only safe because we create a new Smi, which does not cause
   // heap allocation.
   raw_ptr()->bitmap_size_in_bytes_ = Smi::New(value);
 }
 
 
 const char* Stackmap::ToCString() const {
   if (IsNull()) {
     return "{null}";
   } else {
     // Guard against integer overflow, though it is highly unlikely.
     if (MaximumBitIndex() > kIntptrMax / 4) {
-      FATAL1("MaximumBitIndex() is unexpectedly large (%ld)",
+      FATAL1("MaximumBitIndex() is unexpectedly large (%" PRIdPTR ")",
              MaximumBitIndex());
     }
-    intptr_t index = OS::SNPrint(NULL, 0, "0x%lx { ", PC());
+    intptr_t index = OS::SNPrint(NULL, 0, "0x%" PRIxPTR " { ", PC());
     intptr_t alloc_size =
         index + ((MaximumBitIndex() + 1) * 2) + 2;  // "{ 1 0 .... }".
     Isolate* isolate = Isolate::Current();
     char* chars = isolate->current_zone()->Alloc<char>(alloc_size);
-    index = OS::SNPrint(chars, alloc_size, "0x%lx { ", PC());
+    index = OS::SNPrint(chars, alloc_size, "0x%" PRIxPTR " { ", PC());
     for (intptr_t i = 0; i <= MaximumBitIndex(); i++) {
       index += OS::SNPrint((chars + index),
                            (alloc_size - index),
                            "%d ",
                            IsObject(i) ? 1 : 0);
     }
     OS::SNPrint((chars + index), (alloc_size - index), "}");
     return chars;
   }
 }
@@ skipping 4283 matching lines @@
 const char* JSRegExp::ToCString() const {
   const String& str = String::Handle(pattern());
   const char* format = "JSRegExp: pattern=%s flags=%s";
   intptr_t len = OS::SNPrint(NULL, 0, format, str.ToCString(), Flags());
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len + 1);
   OS::SNPrint(chars, (len + 1), format, str.ToCString(), Flags());
   return chars;
 }
 
 }  // namespace dart