media/audio/audio_device_thread.cc - Issue 10832285: Switch OnMoreData() to use AudioBus.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/audio/audio_device_thread.cc

Issue 10832285: Switch OnMoreData() to use AudioBus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/audio/audio_device_thread.cc

diff --git a/media/audio/audio_device_thread.cc b/media/audio/audio_device_thread.cc

index 3e14d3de53929ae88488fe03fc200c325529ca89..a724b2146d2d2fcf21c4c4f2c36ebb94cafbf615 100644

--- a/media/audio/audio_device_thread.cc

+++ b/media/audio/audio_device_thread.cc

@@ -197,9 +197,9 @@ void AudioDeviceThread::Callback::InitializeOnAudioThread() {

MapSharedMemory();

DCHECK(shared_memory_.memory() != NULL);

- // TODO(dalecurtis): Instead of creating a new AudioBus and memcpy'ing into

- // the shared memory we should wrap the shared memory.

- audio_bus_ = AudioBus::Create(audio_parameters_);

+ DCHECK_EQ(memory_length_,

+ media::AudioBus::CalculateMemorySize(audio_parameters_));

+ audio_bus_ = AudioBus::WrapMemory(audio_parameters_, shared_memory_.memory());

}

} // namespace media.