media/audio/audio_device_thread.cc - Issue 10832285: Switch OnMoreData() to use AudioBus.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: media/audio/audio_device_thread.cc

Issue 10832285: Switch OnMoreData() to use AudioBus. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review ready. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« content/browser/renderer_host/media/audio_sync_reader.cc ('K') | « media/audio/android/opensles_output.cc ('k') | media/audio/audio_io.h » ('j') | media/audio/mac/audio_low_latency_output_mac.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "media/audio/audio_device_thread.h"	5 #include "media/audio/audio_device_thread.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/logging.h"	10 #include "base/logging.h"

(...skipping 179 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
190 }	190 }

191	191

192 AudioDeviceThread::Callback::~Callback() {}	192 AudioDeviceThread::Callback::~Callback() {}

193	193

194 void AudioDeviceThread::Callback::InitializeOnAudioThread() {	194 void AudioDeviceThread::Callback::InitializeOnAudioThread() {

195 DCHECK(!audio_bus_.get());	195 DCHECK(!audio_bus_.get());

196	196

197 MapSharedMemory();	197 MapSharedMemory();

198 DCHECK(shared_memory_.memory() != NULL);	198 DCHECK(shared_memory_.memory() != NULL);

199	199

200 // TODO(dalecurtis): Instead of creating a new AudioBus and memcpy'ing into	200 audio_bus_ = AudioBus::WrapMemory(audio_parameters_, shared_memory_.memory());
	Chris Rogers 2012/08/24 20:20:26 I think we should have a sanity check that the aud I think we should have a sanity check that the audio_parameters_ reflects the actual size of the shared_memory_ (and not just accept it on faith from what the browser gives back to us) DaleCurtis 2012/08/24 23:53:12 Done. Show quoted text On 2012/08/24 20:20:26, Chris Rogers wrote: > I think we should have a sanity check that the audio_parameters_ reflects the > actual size of the shared_memory_ (and not just accept it on faith from what the > browser gives back to us) Done.
201 // the shared memory we should wrap the shared memory.

202 audio_bus_ = AudioBus::Create(audio_parameters_);

203 }	201 }

204	202

205 } // namespace media.	203 } // namespace media.

OLD	NEW