Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 10832284: Upstream ContentView contentDescription (Closed)

Created:
8 years, 4 months ago by David Trainor- moved to gerrit
Modified:
8 years, 4 months ago
Reviewers:
Ted C, Yaron
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Upstream ContentView contentDescription Add a contentDescription to ContentView BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151590

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -0 lines) Patch
M content/public/android/java/src/org/chromium/content/app/AppResource.java View 1 chunk +3 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 2 chunks +10 lines, -0 lines 0 comments Download
M content/shell/android/java/src/org/chromium/content_shell/ContentShellActivity.java View 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/android/res/values/strings.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
David Trainor- moved to gerrit
8 years, 4 months ago (2012-08-14 00:05:25 UTC) #1
Ted C
lgtm
8 years, 4 months ago (2012-08-14 00:06:11 UTC) #2
Yaron
lgtm
8 years, 4 months ago (2012-08-14 00:40:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/10832284/1
8 years, 4 months ago (2012-08-14 00:42:39 UTC) #4
commit-bot: I haz the power
Try job failure for 10832284-1 (retry) on linux_chromeos for steps "browser_tests, content_browsertests". It's a second ...
8 years, 4 months ago (2012-08-14 05:18:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtrainor@chromium.org/10832284/1
8 years, 4 months ago (2012-08-14 17:05:11 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 22:47:18 UTC) #7
Change committed as 151590

Powered by Google App Engine
This is Rietveld 408576698