Issue 10832276: gdata: Remove use of FindEntryByPathAsyncOnUI from CreateFileOnUIThread()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832276: gdata: Remove use of FindEntryByPathAsyncOnUI from CreateFileOnUIThread() (Closed)

Created:
8 years, 4 months ago by satorux1

Modified:
8 years, 4 months ago

Reviewers:
achuithb

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

gdata: Remove use of FindEntryByPathAsyncOnUI from CreateFileOnUIThread() By the time CreateFileOnUIThread() is called, the feed is already fetched so there is no need to use FindEntryByPathAsyncOnUI() which initiates the feed loading as needed. Along the way, make callback parameter of CreateFile() mandatory. BUG=142420, 126634 TEST=editing a photo from Files.app works as before. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151359

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -11 lines)			Patch
M	chrome/browser/chromeos/gdata/gdata_file_system.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system.cc	View	3 chunks	+12 lines, -10 lines	0 comments	Download
M	chrome/browser/chromeos/gdata/gdata_file_system_interface.h	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

lgtm

Expand Messages | Collapse Messages