Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Unified Diff: runtime/bin/dartutils.cc

Issue 10832269: Revert "Start adding TLS (SSL) sockets to dart:io." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/dartutils.h ('k') | runtime/bin/file.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dartutils.cc
diff --git a/runtime/bin/dartutils.cc b/runtime/bin/dartutils.cc
index eaf5ec06e9ed31f3463397f51c21cf781d65c095..6939332786ac04bb663718db0f9d879c8dccd611 100644
--- a/runtime/bin/dartutils.cc
+++ b/runtime/bin/dartutils.cc
@@ -304,13 +304,6 @@ bool DartUtils::PostInt32(Dart_Port port_id, int32_t value) {
}
-Dart_Handle DartUtils::GetDartClass(const char* library_url,
- const char* class_name) {
- return Dart_GetClass(Dart_LookupLibrary(Dart_NewString(library_url)),
- Dart_NewString(class_name));
-}
-
-
Dart_Handle DartUtils::NewDartOSError() {
// Extract the current OS error.
OSError os_error;
@@ -320,29 +313,21 @@ Dart_Handle DartUtils::NewDartOSError() {
Dart_Handle DartUtils::NewDartOSError(OSError* os_error) {
// Create a Dart OSError object with the information retrieved from the OS.
- Dart_Handle clazz = GetDartClass(kIOLibURL, "OSError");
+ Dart_Handle url = Dart_NewString("dart:io");
+ if (Dart_IsError(url)) return url;
+ Dart_Handle lib = Dart_LookupLibrary(url);
+ if (Dart_IsError(lib)) return lib;
+ Dart_Handle class_name = Dart_NewString("OSError");
+ if (Dart_IsError(class_name)) return class_name;
+ Dart_Handle clazz = Dart_GetClass(lib, class_name);
+ if (Dart_IsError(clazz)) return clazz;
Dart_Handle args[2];
args[0] = Dart_NewString(os_error->message());
+ if (Dart_IsError(args[0])) return args[0];
args[1] = Dart_NewInteger(os_error->code());
- return Dart_New(clazz, Dart_Null(), 2, args);
-}
-
-
-Dart_Handle DartUtils::NewDartExceptionWithMessage(const char* library_url,
- const char* exception_name,
- const char* message) {
- // Create a Dart Exception object with a message.
- Dart_Handle clazz = GetDartClass(library_url, exception_name);
- Dart_Handle args[1];
- args[0] = Dart_NewString(message);
- return Dart_New(clazz, Dart_Null(), 1, args);
-}
-
-
-Dart_Handle DartUtils::NewDartIllegalArgumentException(const char* message) {
- return NewDartExceptionWithMessage(kCoreLibURL,
- "IllegalArgumentException",
- message);
+ if (Dart_IsError(args[1])) return args[1];
+ Dart_Handle err = Dart_New(clazz, Dart_Null(), 2, args);
+ return err;
}
« no previous file with comments | « runtime/bin/dartutils.h ('k') | runtime/bin/file.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698