Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Unified Diff: content/renderer/render_thread_impl.h

Issue 10832264: Fix lifecycle-vs-threads of GpuVDAContext3D. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_thread_impl.h
diff --git a/content/renderer/render_thread_impl.h b/content/renderer/render_thread_impl.h
index 5ffdda184c02ec26dee41f10d9817c7e46796466..3849519eb139dfc34997a528029b694a228da41a 100644
--- a/content/renderer/render_thread_impl.h
+++ b/content/renderer/render_thread_impl.h
@@ -218,9 +218,12 @@ class CONTENT_EXPORT RenderThreadImpl : public content::RenderThread,
// Returns a graphics context shared among all
// RendererGpuVideoDecoderFactories, or NULL on error. Context remains owned
// by this class and must be null-tested before each use to detect context
- // loss. The returned WeakPtr<> is only valid on the compositor thread when
+ // loss. The returned context is only valid on the compositor thread when
// threaded compositing is enabled.
- base::WeakPtr<WebGraphicsContext3DCommandBufferImpl> GetGpuVDAContext3D();
+ WebGraphicsContext3DCommandBufferImpl* GetGpuVDAContext3D();
+
+ // Handle loss of the shared GpuVDAContext3D context above.
+ static void OnGpuVDAContextLoss();
// AudioRendererMixerManager instance which manages renderer side mixer
// instances shared based on configured audio parameters. Lazily created on

Powered by Google App Engine
This is Rietveld 408576698