Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Unified Diff: content/renderer/media/renderer_gpu_video_decoder_factories.h

Issue 10832264: Fix lifecycle-vs-threads of GpuVDAContext3D. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fwd declare callback class. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/media/renderer_gpu_video_decoder_factories.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/renderer_gpu_video_decoder_factories.h
diff --git a/content/renderer/media/renderer_gpu_video_decoder_factories.h b/content/renderer/media/renderer_gpu_video_decoder_factories.h
index 89efa54c41b693c0f7440a2a7a874de76bdf7331..a9b27e34b41caefef70d4ddd8ae16b6e1605dcf9 100644
--- a/content/renderer/media/renderer_gpu_video_decoder_factories.h
+++ b/content/renderer/media/renderer_gpu_video_decoder_factories.h
@@ -32,12 +32,12 @@ class WaitableEvent;
class CONTENT_EXPORT RendererGpuVideoDecoderFactories
: public media::GpuVideoDecoder::Factories {
public:
- // Takes a ref on |gpu_channel_host| and tests |context| for NULL before each
+ // Takes a ref on |gpu_channel_host| and tests |context| for loss before each
// use.
RendererGpuVideoDecoderFactories(
GpuChannelHost* gpu_channel_host,
const scoped_refptr<base::MessageLoopProxy>& message_loop,
- const base::WeakPtr<WebGraphicsContext3DCommandBufferImpl>& wgc3dcbi);
+ WebGraphicsContext3DCommandBufferImpl* wgc3dcbi);
virtual media::VideoDecodeAccelerator* CreateVideoDecodeAccelerator(
media::VideoCodecProfile profile,
@@ -58,7 +58,8 @@ class CONTENT_EXPORT RendererGpuVideoDecoderFactories
private:
// Helper for the constructor to acquire the ContentGLContext on the
// compositor thread (when it is enabled).
- void AsyncGetContext(base::WaitableEvent* waiter);
+ void AsyncGetContext(WebGraphicsContext3DCommandBufferImpl* context,
+ base::WaitableEvent* waiter);
// Async versions of the public methods. They use output parameters instead
// of return values and each takes a WaitableEvent* param to signal completion
« no previous file with comments | « no previous file | content/renderer/media/renderer_gpu_video_decoder_factories.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698