Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10832259: Extensions Docs Server: Apps api_index.html shows correct APIs (Closed)

Created:
8 years, 4 months ago by cduvall
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Extensions Docs Server: Apps api_index.html shows correct APIs The api_index page for Apps did not show the correct files. This was because the converter script was grabbing all APIs that could be in packaged_apps and hosted_apps, when it should have just been using platform_apps. BUG=142016 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151290

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -48 lines) Patch
M chrome/common/extensions/docs/server2/api_list_data_source.py View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/common/extensions/docs/server2/converter.py View 2 chunks +11 lines, -11 lines 2 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/bookmarks.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/browsingData.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/contentSettings.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/cookies.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/debugger.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/declarativeWebRequest.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/downloads.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_browsingData.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_commands.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_contentSettings.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_cookies.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_debugger.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_devtools.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_devtools_audits.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_devtools_console.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_discovery.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_history.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_infobars.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_offscreenTabs.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_privacy.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_processes.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_speechInput.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/experimental_webRequest.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/fileBrowserHandler.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/fontSettings.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/history.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/input_ime.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/management.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/pageCapture.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/privacy.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/proxy.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/tabs.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/topSites.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/ttsEngine.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/webNavigation.html View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/common/extensions/docs/server2/templates/public/apps/webRequest.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
cduvall
8 years, 4 months ago (2012-08-11 00:47:19 UTC) #1
not at google - send to devlin
lgtm but not sure what to do about orphaned APIs if there are any. https://chromiumcodereview.appspot.com/10832259/diff/1/chrome/common/extensions/docs/server2/converter.py ...
8 years, 4 months ago (2012-08-13 01:56:35 UTC) #2
cduvall
8 years, 4 months ago (2012-08-13 16:58:10 UTC) #3 
http://codereview.chromium.org/10832259/diff/1/chrome/common/extensions/docs/...
File chrome/common/extensions/docs/server2/converter.py (right):

http://codereview.chromium.org/10832259/diff/1/chrome/common/extensions/docs/...
chrome/common/extensions/docs/server2/converter.py:98:
return_list.append('extensions')
On 2012/08/13 01:56:35, kalman wrote:
> Are there any APIs that would be orphaned here?

I don't think there are. If the API isn't in the permissions, then it defaults
to extensions and apps. If an API is in the permissions, it needs to say
explicitly if it has extensions or apps permissions. I think this should work.

Powered by Google App Engine
This is Rietveld 408576698