Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 10832255: app_list: Improve visual feedback for invalid touch scroll. (Closed)

Created:
8 years, 4 months ago by xiyuan
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

app_list: Improve visual feedback for invalid touch scroll. - Reduce col padding for invalid transition to 15px and use a 50px for first column; - Fix a problem that invalid transition gets reset when touch scroll is more than 100%; BUG=none. TEST=Verify icon moves less when attempting touch scroll to an invalid page. Also invalid move is not abruptly reset in the middle while dragging the touch. R=sky@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M ui/app_list/apps_grid_view.cc View 3 chunks +10 lines, -3 lines 0 comments Download
M ui/app_list/pagination_model.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
8 years, 4 months ago (2012-08-10 21:10:38 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-10 22:36:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10832255/1
8 years, 4 months ago (2012-08-10 22:40:14 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-11 01:20:57 UTC) #4
Change committed as 151174

Powered by Google App Engine
This is Rietveld 408576698