Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: ash/launcher/launcher_view.cc

Issue 10832247: chromeos: Add UMA stats for launcher and app list. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: sort UserMetricsAction Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ash/shell_delegate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ash/launcher/launcher_view.cc
diff --git a/ash/launcher/launcher_view.cc b/ash/launcher/launcher_view.cc
index fdcbdb0ba7abfa6a771c79ef2f9b220c7b9c9b14..36f46ff3bc173c72ac0801a6252b69e6cae0afd8 100644
--- a/ash/launcher/launcher_view.cc
+++ b/ash/launcher/launcher_view.cc
@@ -1025,16 +1025,27 @@ void LauncherView::ButtonPressed(views::Button* sender,
switch (model_->items()[view_index].type) {
case TYPE_TABBED:
case TYPE_APP_PANEL:
+ delegate_->ItemClicked(model_->items()[view_index], event.flags());
+ break;
+
case TYPE_APP_SHORTCUT:
case TYPE_PLATFORM_APP:
+ Shell::GetInstance()->delegate()->RecordUserMetricsAction(
+ UMA_LAUNCHER_CLICK_ON_APP);
delegate_->ItemClicked(model_->items()[view_index], event.flags());
break;
case TYPE_APP_LIST:
+ Shell::GetInstance()->delegate()->RecordUserMetricsAction(
+ UMA_LAUNCHER_CLICK_ON_APPLIST_BUTTON);
Shell::GetInstance()->ToggleAppList();
break;
case TYPE_BROWSER_SHORTCUT:
+ // Click on browser icon is counted in app clicks.
+ Shell::GetInstance()->delegate()->RecordUserMetricsAction(
+ UMA_LAUNCHER_CLICK_ON_APP);
+
if (event.flags() & ui::EF_CONTROL_DOWN)
delegate_->CreateNewWindow();
else
« no previous file with comments | « no previous file | ash/shell_delegate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698