Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 10832243: InputTagSpeechDispatcher: don't try to compensate for scrolling (Closed)

Created:
8 years, 4 months ago by hans
Modified:
8 years, 4 months ago
Reviewers:
jamesr, Satish
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

InputTagSpeechDispatcher: don't try to compensate for scrolling Don't try compensate for scrolling on the rect position. This doesn't work anyway, and should be handled properly in WebCore. BUG=141097 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151555

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/renderer/input_tag_speech_dispatcher.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
hans
The WebKit side is being fixed here: https://bugs.webkit.org/show_bug.cgi?id=93634
8 years, 4 months ago (2012-08-10 11:16:30 UTC) #1
Satish
LGTM in context of the webkit CL
8 years, 4 months ago (2012-08-10 12:58:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10832243/1
8 years, 4 months ago (2012-08-14 09:16:26 UTC) #3
commit-bot: I haz the power
Presubmit check for 10832243-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-14 09:16:28 UTC) #4
hans
jamesr: OWNERS for content/renderer?
8 years, 4 months ago (2012-08-14 09:18:23 UTC) #5
jamesr
lgtm
8 years, 4 months ago (2012-08-14 16:55:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hans@chromium.org/10832243/1
8 years, 4 months ago (2012-08-14 17:02:12 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 20:31:08 UTC) #8
Change committed as 151555

Powered by Google App Engine
This is Rietveld 408576698