Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: lib/compiler/implementation/dart_backend/placeholder_collector.dart

Issue 10832242: Traverse newly discovered elements to pick more referenced types. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/compiler/implementation/dart_backend/backend.dart ('k') | tests/compiler/dart2js/unparser_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/compiler/implementation/dart_backend/placeholder_collector.dart
diff --git a/lib/compiler/implementation/dart_backend/placeholder_collector.dart b/lib/compiler/implementation/dart_backend/placeholder_collector.dart
index fadb9404dc032a8337f6ceef1397a90b280eaa63..76a8ff03e693cb1f8be2478a84d4f33e137cfa3f 100644
--- a/lib/compiler/implementation/dart_backend/placeholder_collector.dart
+++ b/lib/compiler/implementation/dart_backend/placeholder_collector.dart
@@ -145,6 +145,9 @@ class PlaceholderCollector extends AbstractVisitor {
currentElement = element.variables;
elementNode = currentElement.parseNode(compiler);
collectFieldDeclarationPlaceholders(element, elementNode);
+ } else if (element is ClassElement || element is TypedefElement) {
+ currentElement = element;
+ elementNode = currentElement.parseNode(compiler);
} else {
assert(false); // Unreachable.
}
@@ -192,10 +195,6 @@ class PlaceholderCollector extends AbstractVisitor {
visitNode(Node node) { node.visitChildren(this); } // We must go deeper.
- visitClassNode(ClassNode node) {
- internalError('Should never meet ClassNode', node);
- }
-
visitSend(Send send) {
new SendVisitor(this, treeElements).visitSend(send);
send.visitChildren(this);
« no previous file with comments | « lib/compiler/implementation/dart_backend/backend.dart ('k') | tests/compiler/dart2js/unparser_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698