chrome/browser/extensions/extension_crash_recovery_browsertest.cc - Issue 10832237: Allow chrome.management.setEnabled() to re-enable crashed extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

Issue 10832237: Allow chrome.management.setEnabled() to re-enable crashed extensions. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Navigate to about:crash instead of using base::KillProcess Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/management/management_api.cc ('K') | « chrome/browser/extensions/api/management/management_api_browsertest.cc ('k') | chrome/browser/extensions/extension_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_crash_recovery_browsertest.cc

diff --git a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

index 509d2120b0191f2d71b79ffcd30ea1c70da3e9c7..deccdd24cfd84d9bbfb240ead7b5e4263d6f494a 100644

--- a/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

+++ b/chrome/browser/extensions/extension_crash_recovery_browsertest.cc

@@ -73,16 +73,14 @@ class ExtensionCrashRecoveryTest : public ExtensionBrowserTest {

void CrashExtension(std::string extension_id) {

const Extension* extension =

- GetExtensionService()->extensions()->GetByID(extension_id);

+ GetExtensionService()->GetExtensionById(extension_id, false);

ASSERT_TRUE(extension);

extensions::ExtensionHost* extension_host = GetExtensionProcessManager()->

GetBackgroundHostForExtension(extension_id);

ASSERT_TRUE(extension_host);

- content::RenderProcessHost* extension_rph =

- extension_host->render_view_host()->GetProcess();

- base::KillProcess(extension_rph->GetHandle(), content::RESULT_CODE_KILLED,

- false);

+ base::KillProcess(extension_host->render_process_host()->GetHandle(),

+ content::RESULT_CODE_KILLED, false);

ASSERT_TRUE(WaitForExtensionCrash(extension_id));

ASSERT_FALSE(GetExtensionProcessManager()->

GetBackgroundHostForExtension(extension_id));