Allow chrome.management.setEnabled() to re-enable crashed extensions.

chrome/browser/extensions/api/management/management_api_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/scoped_temp_dir.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "chrome/browser/extensions/api/management/management_api.h"
 #include "chrome/browser/extensions/api/management/management_api_constants.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
+#include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_install_dialog.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
+#include "chrome/common/extensions/extension.h"
+#include "content/public/browser/render_process_host.h"
+#include "content/public/browser/render_view_host.h"
+#include "content/public/common/result_codes.h"
 
 namespace keys = extension_management_api_constants;
 namespace util = extension_function_test_utils;
 
 class ExtensionManagementApiBrowserTest : public ExtensionBrowserTest {};
 
 // We test this here instead of in an ExtensionApiTest because normal extensions
 // are not allowed to call the install function.
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiBrowserTest, InstallEvent) {
   ExtensionTestMessageListener listener1("ready", false);
@@ skipping 123 matching lines @@
         browser(),
         util::NONE);
     if (expected_error.empty()) {
       EXPECT_EQ(true, response);
     } else {
       EXPECT_TRUE(response == false);
       EXPECT_EQ(expected_error, function->GetError());
     }
   }
 
+  bool CrashEnabledExtension(const std::string& extension_id) {
+    const extensions::Extension* extension = browser()->profile()->
+        GetExtensionService()->GetExtensionById(extension_id, false);
+    if (!extension)
+      return false;
+    extensions::ExtensionHost* extension_host = browser()->profile()->
+        GetExtensionProcessManager()->GetBackgroundHostForExtension(
+            extension_id);
+    if (!extension_host)
+      return false;
+    base::KillProcess(
+        extension_host->render_view_host()->GetProcess()->GetHandle(),
+        content::RESULT_CODE_KILLED, false);
+    return WaitForExtensionCrash(extension_id);
+  }
+
  private:
   ScopedTempDir scoped_temp_dir_;
 };
 
 const char ExtensionManagementApiEscalationTest::kId[] =
     "pgdpcfcocojkjfbgpiianjngphoopgmo";
 
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiEscalationTest,
                        DisabledReason) {
   scoped_refptr<GetExtensionByIdFunction> function =
@@ skipping 18 matching lines @@
 
   // Expect an error that user cancelled the dialog.
   CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kAppsGalleryInstallAutoConfirmForTests, "cancel");
   ReEnable(true, keys::kUserDidNotReEnableError);
 
   // This should succeed when user accepts dialog.
   CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kAppsGalleryInstallAutoConfirmForTests, "accept");
   ReEnable(true, "");
+
+  // Crash the extension and confirm re-enabling works.
+  ASSERT_TRUE(CrashEnabledExtension(kId));
+  ReEnable(true, "");

[asargent_no_longer_on_chrome, 2012/08/10 20:26:21]

can you also add a test here that calls SetEnabled(false) on a crashed
extension?

[mitchellwrosen, 2012/08/10 23:15:27]

Ya. The expected behavior is that the extension is reloaded and left disabled,
right?

 }