Allow chrome.management.setEnabled() to re-enable crashed extensions.

chrome/browser/extensions/api/management/management_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/management_api.h"
 
 #include <map>
 #include <string>
 
 #include "base/basictypes.h"
@@ skipping 389 matching lines @@
 
 SetEnabledFunction::~SetEnabledFunction() {
 }
 
 bool SetEnabledFunction::RunImpl() {
   bool enable;
   EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &extension_id_));
   EXTENSION_FUNCTION_VALIDATE(args_->GetBoolean(1, &enable));
 
   const Extension* extension = service()->GetExtensionById(extension_id_, true);
+  // The extension may have been unloaded due to a crash.
   if (!extension) {
-    error_ = ExtensionErrorUtils::FormatErrorMessage(
-        keys::kNoExtensionError, extension_id_);
-    return false;
+    UnloadedExtensionPathMap::const_iterator iter = service()->
+        unloaded_extension_paths().find(extension_id_);

[asargent_no_longer_on_chrome, 2012/08/10 20:26:21]

I'm not sure operating on unloaded extensions is correct, because that list can
contain both extensions that crashed ("terminated" is the term used in
ExtensionService) but also extensions that are in the process of being
uninstalled. I'm concerned that this could be a way for an extension to prevent
uninstallation of other extensions. 

Can you instead grab the terminated_extensions() list from ExtensionService and
check if the extension is in there?

[mitchellwrosen, 2012/08/10 23:15:27]

Thanks, I didn't catch the "terminated" keyword. Much simpler, now.

+    if (iter != service()->unloaded_extension_paths().end()) {
+      if (enable)
+        service()->ReloadExtension(extension_id_);
+
+      BrowserThread::PostTask(
+          BrowserThread::UI,
+          FROM_HERE,
+          base::Bind(&SetEnabledFunction::SendResponse, this, true));
+      return true;
+    } else {
+      error_ = ExtensionErrorUtils::FormatErrorMessage(
+          keys::kNoExtensionError, extension_id_);
+      return false;
+    }
   }
 
   const extensions::ManagementPolicy* policy = extensions::ExtensionSystem::Get(
       profile())->management_policy();
   if (!policy->UserMayModifySettings(extension, NULL)) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
         keys::kUserCantModifyError, extension_id_);
     return false;
   }
 
@@ skipping 181 matching lines @@
       extension = content::Details<const Extension>(details).ptr();
     }
     CHECK(extension);
     ExtensionService* service = profile->GetExtensionService();
     args->Append(CreateExtensionInfo(*extension, service));
   }
 
   profile->GetExtensionEventRouter()->DispatchEventToRenderers(
       event_name, args.Pass(), NULL, GURL(), extensions::EventFilteringInfo());
 }