Allow chrome.management.setEnabled() to re-enable crashed extensions.

chrome/browser/extensions/api/management/management_api_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/file_path.h"
 #include "base/scoped_temp_dir.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "chrome/browser/extensions/api/management/management_api.h"
 #include "chrome/browser/extensions/api/management/management_api_constants.h"
 #include "chrome/browser/extensions/extension_browsertest.h"
 #include "chrome/browser/extensions/extension_function_test_utils.h"
+#include "chrome/browser/extensions/extension_host.h"
 #include "chrome/browser/extensions/extension_install_dialog.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/extension_test_message_listener.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "chrome/common/chrome_switches.h"
+#include "content/public/browser/notification_service.h"
+#include "content/public/common/url_constants.h"
+#include "content/public/test/test_utils.h"
 
 namespace keys = extension_management_api_constants;
 namespace util = extension_function_test_utils;
 
 class ExtensionManagementApiBrowserTest : public ExtensionBrowserTest {};
 
 // We test this here instead of in an ExtensionApiTest because normal extensions
 // are not allowed to call the install function.
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiBrowserTest, InstallEvent) {
   ExtensionTestMessageListener listener1("ready", false);
@@ skipping 106 matching lines @@
     EXPECT_TRUE(service->GetExtensionById(kId, false) != NULL);
 
     // Update to a high-permission version - it should get disabled.
     EXPECT_FALSE(UpdateExtension(kId, path_v2, -1));
     EXPECT_TRUE(service->GetExtensionById(kId, false) == NULL);
     EXPECT_TRUE(service->GetExtensionById(kId, true) != NULL);
     EXPECT_TRUE(
         service->extension_prefs()->DidExtensionEscalatePermissions(kId));
   }
 
-  void ReEnable(bool user_gesture, const std::string& expected_error) {
+  void SetEnabled(bool enabled, bool user_gesture,
+                  const std::string& expected_error) {
     scoped_refptr<SetEnabledFunction> function(new SetEnabledFunction);
+    const char* enabled_string = enabled ? "true" : "false";
     if (user_gesture)
       function->set_user_gesture(true);
     bool response = util::RunFunction(
         function.get(),
-        base::StringPrintf("[\"%s\", true]", kId),
+        base::StringPrintf("[\"%s\", %s]", kId, enabled_string),
         browser(),
         util::NONE);
     if (expected_error.empty()) {
       EXPECT_EQ(true, response);
     } else {
       EXPECT_TRUE(response == false);
       EXPECT_EQ(expected_error, function->GetError());
     }
   }
 
+  bool CrashEnabledExtension(const std::string& extension_id) {
+    content::WindowedNotificationObserver extension_crash_observer(
+        chrome::NOTIFICATION_EXTENSION_PROCESS_TERMINATED,
+        content::NotificationService::AllSources());
+    extensions::ExtensionHost* background_host =
+        browser()->profile()->GetExtensionProcessManager()->
+            GetBackgroundHostForExtension(extension_id);
+    if (!background_host)
+      return false;
+    background_host->host_contents()->GetController().LoadURL(
+        GURL(chrome::kChromeUICrashURL), content::Referrer(),
+        content::PAGE_TRANSITION_LINK, std::string());
+    extension_crash_observer.Wait();
+    return true;
+  }
+
  private:
   ScopedTempDir scoped_temp_dir_;
 };
 
 const char ExtensionManagementApiEscalationTest::kId[] =
     "pgdpcfcocojkjfbgpiianjngphoopgmo";
 
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiEscalationTest,
                        DisabledReason) {
   scoped_refptr<GetExtensionByIdFunction> function =
       new GetExtensionByIdFunction();
   scoped_ptr<base::Value> result(util::RunFunctionAndReturnSingleResult(
       function.get(),
       base::StringPrintf("[\"%s\"]", kId),
       browser()));
   ASSERT_TRUE(result.get() != NULL);
   ASSERT_TRUE(result->IsType(base::Value::TYPE_DICTIONARY));
   base::DictionaryValue* dict =
       static_cast<base::DictionaryValue*>(result.get());
   std::string reason;
   EXPECT_TRUE(dict->GetStringASCII(keys::kDisabledReasonKey, &reason));
   EXPECT_EQ(reason, std::string(keys::kDisabledReasonPermissionsIncrease));
 }
 
 IN_PROC_BROWSER_TEST_F(ExtensionManagementApiEscalationTest,
-                       ReEnable) {
+                       SetEnabled) {
   // Expect an error about no gesture.
-  ReEnable(false, keys::kGestureNeededForEscalationError);
+  SetEnabled(true, false, keys::kGestureNeededForEscalationError);
 
   // Expect an error that user cancelled the dialog.
   CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kAppsGalleryInstallAutoConfirmForTests, "cancel");
-  ReEnable(true, keys::kUserDidNotReEnableError);
+  SetEnabled(true, true, keys::kUserDidNotReEnableError);
 
   // This should succeed when user accepts dialog.
   CommandLine::ForCurrentProcess()->AppendSwitchASCII(
       switches::kAppsGalleryInstallAutoConfirmForTests, "accept");
-  ReEnable(true, "");
+  SetEnabled(true, true, "");
+
+  // Crash the extension and try to enable. The extension should be reloaded and
+  // enabled.
+  ASSERT_TRUE(CrashEnabledExtension(kId));
+  SetEnabled(true, true, "");
+
+  // Crash the extension again and try to disable. This call should be a no-op
+  // and the extension should remain unloaded.
+  ASSERT_TRUE(CrashEnabledExtension(kId));
+  SetEnabled(false, true, "");
+  const extensions::Extension* extension = browser()->profile()->
+      GetExtensionService()->GetTerminatedExtension(kId);
+  ASSERT_TRUE(extension);
 }