Allow chrome.management.setEnabled() to re-enable crashed extensions.

chrome/browser/extensions/api/management/management_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/management/management_api.h"
 
 #include <map>
 #include <string>
 #include <vector>
 
@@ skipping 429 matching lines @@
 SetEnabledFunction::~SetEnabledFunction() {
 }
 
 bool SetEnabledFunction::RunImpl() {
   scoped_ptr<management::SetEnabled::Params> params(
       management::SetEnabled::Params::Create(*args_));
   EXTENSION_FUNCTION_VALIDATE(params.get());
 
   extension_id_ = params->id;
 
-  const Extension* extension = service()->GetExtensionById(extension_id_, true);
+  const Extension* extension = service()->GetInstalledExtension(extension_id_);
   if (!extension) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
         keys::kNoExtensionError, extension_id_);
     return false;
   }
 
+  // The extension may have been unloaded due to a crash.

[Aaron Boodman, 2012/09/04 22:47:19]

Does not seem right that this code is before policy check below.

+  if (service()->GetTerminatedExtension(extension_id_)) {
+    if (params->enabled) {
+      service()->ReloadExtension(extension_id_);

[Aaron Boodman, 2012/09/04 22:47:19]

Why this special case? Just make this extension affect terminated extensions
exactly as it does non-terminated ones.

[mitchellwrosen, 2012/09/04 23:00:08]

Isn't it a special case, though? Terminated extensions have to be reloaded.

+    } else {
+      // Treat setEnabled(false) when the extension has crashed as a no-op.
+      BrowserThread::PostTask(
+          BrowserThread::UI,
+          FROM_HERE,
+          base::Bind(&SetEnabledFunction::SendResponse, this, true));
+      return true;
+    }
+  }
+
   const extensions::ManagementPolicy* policy = extensions::ExtensionSystem::Get(
       profile())->management_policy();
   if (!policy->UserMayModifySettings(extension, NULL)) {
     error_ = ExtensionErrorUtils::FormatErrorMessage(
         keys::kUserCantModifyError, extension_id_);
     return false;
   }
 
   bool currently_enabled = service()->IsExtensionEnabled(extension_id_);
 
@@ skipping 176 matching lines @@
     }
     CHECK(extension);
     scoped_ptr<management::ExtensionInfo> info = CreateExtensionInfo(
         *extension, ExtensionSystem::Get(profile));
     args->Append(info->ToValue().release());
   }
 
   profile->GetExtensionEventRouter()->DispatchEventToRenderers(
       event_name, args.Pass(), NULL, GURL(), extensions::EventFilteringInfo());
 }