gdata: Fix bad function names in GDataFileSystem

gdata: Fix bad function names in GDataFileSystem

- RemoveEntryFromDirectory() was a misnomer. It removes an entry if it's
  not on the root directory. The |dir_path| parameter was unnecessary
  as it can be obtained from |file_path|.
  New name: RemoveEntryFromNonRootDirectory()

- RemoveEntryFromDirectoryOnFileSystem() was a misnomer. It moves an
  entry to the root directory on the client side
  New name: MoveEntryToRootDirectoryOnClientSide()

- Rename *OnFileSystem() with *OnClientSide() to make it clear these are
  client side operations

- Rename OnMoveEntryToDirectoryWithFileMoveCallback() to
  NotifyAndRunFileMoveCallback() based on what it does

- Rename OnMoveEntryToDirectoryWithFileOperationCallback() to
  NotifyAndRunFileOperationCallback() based on what it does

Along the way, eliminate if (!callback.is_null()) and PostTask() from
places where these are unnecessary.

BUG=126634, 139446
TEST=moving and renaming of files on Drive works as before

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151115

[satorux1, 2012-08-09 23:18:27]

This entry moving business is a mess. Hope the new names make us a bit saner.

[achuithb, 2012-08-10 08:59:13]

https://chromiumcodereview.appspot.com/10832233/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

https://chromiumcodereview.appspot.com/10832233/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.cc:1294: const FilePath&
dir_path = file_path.DirName();
Can't use a const reference to a temporary.

https://chromiumcodereview.appspot.com/10832233/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2742:
DCHECK(!callback.is_null());
I believe this happens on the UI thread? Can we add a DCHECK for that? I
neglected to add it in my patch.

https://chromiumcodereview.appspot.com/10832233/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2754:
DCHECK(!callback.is_null());
Can we add a UI thread DCHECK here?

https://chromiumcodereview.appspot.com/10832233/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

https://chromiumcodereview.appspot.com/10832233/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.h:504: void
RenameFileOnClientSide(const FilePath& file_path,
Not sure I like OnClientSide. How about Locally? So RenameFileLocally? Same for
others.

https://chromiumcodereview.appspot.com/10832233/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_file_system.h:524: GDataFileError
RemoveEntryOnClientSide(const FilePath& file_path);
Method overloading is forbidden. You need a different name.

[satorux1, 2012-08-10 15:56:03]

http://codereview.chromium.org/10832233/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.cc (right):

http://codereview.chromium.org/10832233/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:1294: const FilePath&
dir_path = file_path.DirName();
On 2012/08/10 08:59:13, achuith.bhandarkar wrote:
> Can't use a const reference to a temporary. 

Good catch! Done.

http://codereview.chromium.org/10832233/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2742:
DCHECK(!callback.is_null());
On 2012/08/10 08:59:13, achuith.bhandarkar wrote:
> I believe this happens on the UI thread? Can we add a DCHECK for that? I
> neglected to add it in my patch.

Done.

http://codereview.chromium.org/10832233/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.cc:2754:
DCHECK(!callback.is_null());
On 2012/08/10 08:59:13, achuith.bhandarkar wrote:
> Can we add a UI thread DCHECK here?

Done.

http://codereview.chromium.org/10832233/diff/1/chrome/browser/chromeos/gdata/...
File chrome/browser/chromeos/gdata/gdata_file_system.h (right):

http://codereview.chromium.org/10832233/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.h:504: void
RenameFileOnClientSide(const FilePath& file_path,
On 2012/08/10 08:59:13, achuith.bhandarkar wrote:
> Not sure I like OnClientSide. How about Locally? So RenameFileLocally? Same
for
> others.

Locally sounds good. Fixed everywhere. Kept "on the client side" in function
comments as it sounded slightly more descriptive than locally.

Besides, RenameFileOnClientSide() had to be RenameEntryLocally() as we are
dealing with a file or a directory. Changed.

http://codereview.chromium.org/10832233/diff/1/chrome/browser/chromeos/gdata/...
chrome/browser/chromeos/gdata/gdata_file_system.h:524: GDataFileError
RemoveEntryOnClientSide(const FilePath& file_path);
On 2012/08/10 08:59:13, achuith.bhandarkar wrote:
> Method overloading is forbidden. You need a different name.

Good catch!! Didn't expect a name collision after renaming. Fixed.

[achuithb, 2012-08-10 19:31:05]

Thanks for taking care of the comments.

LGTM!