Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Issue 10832229: Disallow copying of NetworkListObserverPrivate. (Closed)

Created:
8 years, 4 months ago by Sergey Ulanov
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Disallow copying of NetworkListObserverPrivate. It should be prohibited to copy list observer object because otherwise it would be impossible to guarantee that network monitor resource is destroyed when the list observer is destroyed. Also the copied list observer would not work properly anyway. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151103

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M ppapi/utility/private/network_list_observer_private.h View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
8 years, 4 months ago (2012-08-09 21:14:58 UTC) #1
dmichael (off chromium)
lgtm, thanks!
8 years, 4 months ago (2012-08-09 21:39:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10832229/1
8 years, 4 months ago (2012-08-09 21:40:36 UTC) #3
commit-bot: I haz the power
Try job failure for 10832229-1 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-09 21:51:04 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 21:59:07 UTC) #5

Powered by Google App Engine
This is Rietveld 408576698