Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: ui/aura/window.cc

Issue 10832228: Changes aura::Window::observers_ to not notify observers that are (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/aura/window.cc
diff --git a/ui/aura/window.cc b/ui/aura/window.cc
index d125da17555e99eff9576441feca48955bd0b5ab..c981c85535bb4cd475561c9a8607606b6fd30d87 100644
--- a/ui/aura/window.cc
+++ b/ui/aura/window.cc
@@ -66,7 +66,11 @@ Window::Window(WindowDelegate* delegate)
id_(-1),
transparent_(false),
user_data_(NULL),
- ignore_events_(false) {
+ ignore_events_(false),
+ // Don't notify newly added observers during notification. This causes
+ // problems for code that adds an observer as part of an observer
+ // notification (such as the workspace code).
+ observers_(ObserverList<WindowObserver>::NOTIFY_EXISTING_ONLY) {
}
Window::~Window() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698