Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1602)

Issue 10832221: Add keyboard shortcuts for Mac content shell. (Closed)

Created:
8 years, 4 months ago by Shouqun Liu
Modified:
8 years, 4 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add keyboard shortcuts for Mac content shell. Support navigation with keyboard shortcuts as other platform(GTK). BUG=90445 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -6 lines) Patch
M content/shell/shell_mac.mm View 4 chunks +17 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Shouqun Liu
Hi, this patch adds keyboard acceleration support for Mac ontent shell as the GTK version, ...
8 years, 4 months ago (2012-08-09 13:02:34 UTC) #1
jochen (gone - plz use gerrit)
On 2012/08/09 13:02:34, Shouqun Liu wrote: > Hi, this patch adds keyboard acceleration support for ...
8 years, 4 months ago (2012-08-09 13:05:26 UTC) #2
Avi (use Gerrit)
lgtm
8 years, 4 months ago (2012-08-09 14:09:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shouqun.liu@intel.com/10832221/1
8 years, 4 months ago (2012-08-09 14:16:39 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 16:10:05 UTC) #5
Change committed as 150804

Powered by Google App Engine
This is Rietveld 408576698