Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3169)

Unified Diff: chrome/browser/ui/search/search_tab_helper.h

Issue 10832216: Clicks broken in NTP section of Search overlay (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressing comments. Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/search_tab_helper.h
diff --git a/chrome/browser/ui/search/search_tab_helper.h b/chrome/browser/ui/search/search_tab_helper.h
index 4cad6a740c7b75539e3145e7940f5f3827046072..1a80d2272a66cacf45285d800989a08042149241 100644
--- a/chrome/browser/ui/search/search_tab_helper.h
+++ b/chrome/browser/ui/search/search_tab_helper.h
@@ -6,7 +6,6 @@
#define CHROME_BROWSER_UI_SEARCH_SEARCH_TAB_HELPER_H_
#include "base/basictypes.h"
-#include "base/memory/scoped_ptr.h"
#include "chrome/browser/ui/search/search_model.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -15,10 +14,6 @@
class OmniboxEditModel;
class TabContents;
-namespace content {
-class WebContents;
-};
-
namespace chrome {
namespace search {
@@ -34,9 +29,6 @@ class SearchTabHelper : public content::WebContentsObserver,
return &model_;
}
- // Lazily create web contents for NTP. Owned by SearchTabHelper.
- content::WebContents* GetNTPWebContents();
-
// Invoked when the OmniboxEditModel changes state in some way that might
// affect the search mode.
void OmniboxEditModelChanged(OmniboxEditModel* edit_model);
@@ -55,17 +47,11 @@ class SearchTabHelper : public content::WebContentsObserver,
// Sets the mode of the model based on |url|.
void UpdateModel(const GURL& url);
- // On navigation away from NTP and Search pages, delete |ntp_web_contents_|.
- void FlushNTP(const GURL& url);
-
const bool is_search_enabled_;
// Model object for UI that cares about search state.
SearchModel model_;
- // Lazily created web contents for NTP.
- scoped_ptr<content::WebContents> ntp_web_contents_;
-
content::NotificationRegistrar registrar_;
DISALLOW_COPY_AND_ASSIGN(SearchTabHelper);
« no previous file with comments | « no previous file | chrome/browser/ui/search/search_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698