Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 10832207: Browser Plugin: Report Guest crash to Javascript (Closed)

Created:
8 years, 4 months ago by Fady Samuel
Modified:
8 years, 4 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, rjkroege, lazyboy
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Merge with ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -0 lines) Patch
M content/renderer/browser_plugin/browser_plugin.cc View 1 2 chunks +16 lines, -0 lines 0 comments Download
M content/renderer/browser_plugin/browser_plugin_browsertest.cc View 1 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Fady Samuel
Hi John, Charlie is OOO, so I was hoping you could please have a quick ...
8 years, 4 months ago (2012-08-08 18:21:19 UTC) #1
jam
lgtm
8 years, 4 months ago (2012-08-08 18:28:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10832207/1
8 years, 4 months ago (2012-08-09 00:48:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10832207/1
8 years, 4 months ago (2012-08-10 01:57:11 UTC) #4
commit-bot: I haz the power
Failed to apply patch for content/renderer/browser_plugin/browser_plugin_browsertest.cc: While running patch -p1 --forward --force; patching file content/renderer/browser_plugin/browser_plugin_browsertest.cc ...
8 years, 4 months ago (2012-08-10 01:57:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/10832207/10001
8 years, 4 months ago (2012-08-10 02:29:09 UTC) #6
commit-bot: I haz the power
8 years, 4 months ago (2012-08-10 03:53:55 UTC) #7
Change committed as 150989

Powered by Google App Engine
This is Rietveld 408576698