Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 10832204: Add board and isOwner properties to chromeosInfoPrivate (Closed)

Created:
8 years, 4 months ago by Dmitry Polukhin
Modified:
8 years, 4 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Add board and isOwner properties to chromeosInfoPrivate BUG=chrome-os-partner:9659 TEST=browser_tests:ExtensionApiTest.CustomizationPrivateTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150737

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -10 lines) Patch
M chrome/browser/extensions/extension_info_private_api_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_info_private_api_chromeos.cc View 4 chunks +28 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/chromeos_info_private.json View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/test/data/extensions/api_test/chromeos_info_private/background.js View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
Dmitry Polukhin
8 years, 4 months ago (2012-08-08 14:19:43 UTC) #1
Dmitry Polukhin
+ Mihai for OWNER review in extensions
8 years, 4 months ago (2012-08-08 14:27:07 UTC) #2
Nikita (slow)
lgtm
8 years, 4 months ago (2012-08-08 16:36:14 UTC) #3
Mihai Parparita -not on Chrome
LGTM
8 years, 4 months ago (2012-08-09 00:16:06 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/10832204/1
8 years, 4 months ago (2012-08-09 03:03:23 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-09 05:18:07 UTC) #6
Change committed as 150737

Powered by Google App Engine
This is Rietveld 408576698