Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(982)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 10832199: Add a weak property type to the virtual machine. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: address final review comments Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/gc_marker.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc
index b9919bbc066faf724bace3dfa123af2db0e15574..e23c59bf6554bc80de0f4b3b4025fc2554c182bc 100644
--- a/runtime/vm/class_finalizer.cc
+++ b/runtime/vm/class_finalizer.cc
@@ -263,6 +263,8 @@ void ClassFinalizer::VerifyBootstrapClasses() {
ASSERT(ExternalFloat32Array::InstanceSize() == cls.instance_size());
cls = object_store->external_float64_array_class();
ASSERT(ExternalFloat64Array::InstanceSize() == cls.instance_size());
+ cls = object_store->weak_property_class();
+ ASSERT(WeakProperty::InstanceSize() == cls.instance_size());
#endif // defined(DEBUG)
// Remember the currently pending classes.
@@ -374,7 +376,8 @@ void ClassFinalizer::ResolveSuperType(const Class& cls) {
case kFloat32ArrayCid:
case kExternalFloat32ArrayCid:
case kFloat64ArrayCid:
- case kExternalFloat64ArrayCid: {
+ case kExternalFloat64ArrayCid:
+ case kWeakPropertyCid: {
const Script& script = Script::Handle(cls.script());
ReportError(script, cls.token_pos(),
"'%s' is not allowed to extend '%s'",
« no previous file with comments | « no previous file | runtime/vm/gc_marker.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698