[extensions] Don't let clicks on <a href="#"> links escape un-prevented.

[extensions] Don't let clicks on <a href="#"> links escape un-prevented.

Also adds the utility to stop clicks on any page to util.js and makes the NTP a
user of this function.

BUG=136338
TEST=Inspect a background view, options, or reload an extension while scrolled
without being forced to the top of the page.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151127

[Evan Stade, 2012-08-08 20:03:07]

https://chromiumcodereview.appspot.com/10832196/diff/5001/chrome/browser/reso...
File chrome/browser/resources/shared/js/util.js (right):

https://chromiumcodereview.appspot.com/10832196/diff/5001/chrome/browser/reso...
chrome/browser/resources/shared/js/util.js:135: function
preventPoundLinkClicks() {
I think this function name could be improved because it sounds like you're
preventing the click, instead you're actually preventing the default handling.
Since it's only called once per page, and it's called without parameters I think
it's ok to have an extra long and descriptive name.

[Dan Beam, 2012-08-08 20:28:11]

https://chromiumcodereview.appspot.com/10832196/diff/5001/chrome/browser/reso...
File chrome/browser/resources/shared/js/util.js (right):

https://chromiumcodereview.appspot.com/10832196/diff/5001/chrome/browser/reso...
chrome/browser/resources/shared/js/util.js:135: function
preventPoundLinkClicks() {
On 2012/08/08 20:03:07, Evan Stade wrote:
> I think this function name could be improved because it sounds like you're
> preventing the click, instead you're actually preventing the default handling.
> Since it's only called once per page, and it's called without parameters I
think
> it's ok to have an extra long and descriptive name.

preventDefaultOnPoundLinkClicks() ?

[Evan Stade, 2012-08-08 22:16:42]

yea

[Evan Stade, 2012-08-08 22:24:27]

lgtm

[commit-bot: I haz the power, 2012-08-08 23:01:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dbeam@chromium.org/10832196/10001

[commit-bot: I haz the power, 2012-08-08 23:30:31]

Try job failure for 10832196-10001 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...