Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issue 10832194: aura: Fix crash when the aura window hosting a tooltip is destroyed. We fix (Closed)

Created:
8 years, 4 months ago by varunjain
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

aura: Fix crash when the aura window hosting a tooltip is destroyed. We fix this by listening to such events. BUG=140811 TEST=added new test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150488

Patch Set 1 : patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -14 lines) Patch
M ash/tooltips/tooltip_controller.cc View 6 chunks +27 lines, -11 lines 0 comments Download
M ash/tooltips/tooltip_controller_unittest.cc View 4 chunks +50 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
varunjain
8 years, 4 months ago (2012-08-07 23:41:21 UTC) #1
sky
LGTM
8 years, 4 months ago (2012-08-07 23:57:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/varunjain@chromium.org/10832194/2001
8 years, 4 months ago (2012-08-08 01:10:13 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 02:37:21 UTC) #4
Change committed as 150488

Powered by Google App Engine
This is Rietveld 408576698