Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 10832185: FileBrowser: Hide DriveApps on Open-with menu when the selected file is not on drive. (Closed)

Created:
8 years, 4 months ago by yoshiki
Modified:
8 years, 4 months ago
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

FileBrowser: Hide DriveApps on Open-with menu when the selected file is not on drive. BUG=139699 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150806

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/file_tasks.js View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/file_browser_private.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
yoshiki
kaznacheev: Could you take a look?
8 years, 4 months ago (2012-08-07 19:51:00 UTC) #1
yoshiki
+satorux
8 years, 4 months ago (2012-08-07 20:01:42 UTC) #2
satorux1
Thank you for fixing this!! chrome/browser/chromeos/extensions/file_browser_private_api.cc LGTM. JS part should be reviewed by vlad.
8 years, 4 months ago (2012-08-07 20:04:56 UTC) #3
zel
LGTM for chrome/browser/resources/file_manager part
8 years, 4 months ago (2012-08-08 22:16:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/10832185/5
8 years, 4 months ago (2012-08-08 22:16:46 UTC) #5
commit-bot: I haz the power
Presubmit check for 10832185-5 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-08 22:16:51 UTC) #6
yoshiki
Antony: could you take a look at file_browser_private.json?
8 years, 4 months ago (2012-08-08 22:18:15 UTC) #7
asargent_no_longer_on_chrome
file_browser_private.json LGTM
8 years, 4 months ago (2012-08-08 22:19:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/10832185/5
8 years, 4 months ago (2012-08-08 22:19:46 UTC) #9
commit-bot: I haz the power
8 years, 4 months ago (2012-08-08 23:06:42 UTC) #10
Try job failure for 10832185-5 (retry) on android for steps "compile, build"
(clobber build).
It's a second try, previously, steps "compile, build" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android&nu...

Powered by Google App Engine
This is Rietveld 408576698