ui/views/view_unittest.cc - Issue 10832184: Fixed memory leak. Untangled confusing code with menu initialization and ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/view_unittest.cc

Issue 10832184: Fixed memory leak. Untangled confusing code with menu initialization and ownership. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/view_unittest.cc

===================================================================

--- ui/views/view_unittest.cc (revision 150365)

+++ ui/views/view_unittest.cc (working copy)

@@ -1762,7 +1762,7 @@

virtual void SetUp() OVERRIDE {

ViewTest::SetUp();

- test_dialog_ = new TestDialog(&mock_menu_model_);

+ test_dialog_ = new TestDialog(new MockMenuModel());

Widget* window =

Widget::CreateWindowWithBounds(test_dialog_, gfx::Rect(0, 0, 100, 100));

test_dialog_->widget_ = window;

@@ -1779,7 +1779,6 @@

}

TestDialog* test_dialog_;

- MockMenuModel mock_menu_model_;

// This is owned by test_dialog_.

View* button_as_view_;

« no previous file with comments | « ui/views/controls/button/button_dropdown.cc ('k') | no next file » | no next file with comments »