ui/views/controls/button/button_dropdown.h - Issue 10832184: Fixed memory leak. Untangled confusing code with menu initialization and ownership.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/button_dropdown.h

Issue 10832184: Fixed memory leak. Untangled confusing code with menu initialization and ownership. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ui/views/controls/button/button_dropdown.h

===================================================================

--- ui/views/controls/button/button_dropdown.h (revision 150365)

+++ ui/views/controls/button/button_dropdown.h (working copy)

@@ -29,6 +29,7 @@

// The button's class name.

static const char kViewClassName[];

+ // Takes ownership of the |model|.

ButtonDropDown(ButtonListener* listener, ui::MenuModel* model);

virtual ~ButtonDropDown();

@@ -67,7 +68,7 @@

private:

// The model that populates the attached menu.

- ui::MenuModel* model_;

+ scoped_ptr<ui::MenuModel> model_;

// Indicates if menu is currently showing.

bool menu_showing_;

« no previous file with comments | « chrome/browser/ui/views/toolbar_view.cc ('k') | ui/views/controls/button/button_dropdown.cc » ('j') | no next file with comments »