Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3900)

Unified Diff: chrome/browser/ui/views/reload_button.h

Issue 10832184: Fixed memory leak. Untangled confusing code with menu initialization and ownership. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/reload_button.cc » ('j') | chrome/browser/ui/views/reload_button.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/reload_button.h
===================================================================
--- chrome/browser/ui/views/reload_button.h (revision 150365)
+++ chrome/browser/ui/views/reload_button.h (working copy)
@@ -74,8 +74,6 @@
private:
friend class ReloadButtonTest;
- ui::SimpleMenuModel* CreateMenuModel();
-
void ExecuteBrowserCommand(int command, int event_flags);
void ChangeModeInternal(Mode mode);
@@ -103,6 +101,9 @@
// Indicates if reload menu is enabled.
bool menu_enabled_;
+ // The model that populates the attached menu.
+ scoped_ptr<ui::SimpleMenuModel> menu_model_;
+
// The parent class's images_ member is used for the current images,
// and this array is used to hold the alternative images.
// We swap between the two when changing mode.
« no previous file with comments | « no previous file | chrome/browser/ui/views/reload_button.cc » ('j') | chrome/browser/ui/views/reload_button.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698