Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 10832154: Fix dup and dup2 in nacl-mounts (Closed)

Created:
8 years, 4 months ago by davidben
Modified:
8 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Fix dup and dup2 in nacl-mounts Actually wrap it and fix up implementations so they work properly. TEST=DupTest.Simple Committed: https://code.google.com/p/naclports/source/detail?r=615

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -62 lines) Patch
M libraries/nacl-mounts/base/Entry.cc View 3 chunks +17 lines, -0 lines 0 comments Download
M libraries/nacl-mounts/base/KernelProxy.h View 1 chunk +1 line, -0 lines 0 comments Download
M libraries/nacl-mounts/base/KernelProxy.cc View 1 2 4 chunks +35 lines, -53 lines 0 comments Download
A libraries/nacl-mounts/test.nacl/DupTest.cc View 1 1 chunk +50 lines, -0 lines 0 comments Download
M libraries/nacl-mounts/test.nacl/Makefile View 1 chunk +1 line, -0 lines 0 comments Download
M libraries/nacl-mounts/util/SlotAllocator.h View 1 chunk +8 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
davidben
Not really sure what the old code was doing, but this should work. :-)
8 years, 4 months ago (2012-08-05 20:57:03 UTC) #1
eugenis
LGTM https://chromiumcodereview.appspot.com/10832154/diff/5001/libraries/nacl-mounts/base/KernelProxy.cc File libraries/nacl-mounts/base/KernelProxy.cc (right): https://chromiumcodereview.appspot.com/10832154/diff/5001/libraries/nacl-mounts/base/KernelProxy.cc#newcode479 libraries/nacl-mounts/base/KernelProxy.cc:479: return 0; return newfd https://chromiumcodereview.appspot.com/10832154/diff/5001/libraries/nacl-mounts/base/KernelProxy.cc#newcode487 libraries/nacl-mounts/base/KernelProxy.cc:487: return 0; ...
8 years, 4 months ago (2012-08-09 11:10:29 UTC) #2
davidben
https://chromiumcodereview.appspot.com/10832154/diff/5001/libraries/nacl-mounts/base/KernelProxy.cc File libraries/nacl-mounts/base/KernelProxy.cc (right): https://chromiumcodereview.appspot.com/10832154/diff/5001/libraries/nacl-mounts/base/KernelProxy.cc#newcode479 libraries/nacl-mounts/base/KernelProxy.cc:479: return 0; On 2012/08/09 11:10:29, eugenis wrote: > return ...
8 years, 4 months ago (2012-08-10 01:09:04 UTC) #3
Evgeniy Stepanov
8 years, 4 months ago (2012-08-13 17:12:37 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698