Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1066)

Issue 10832151: Add kSeekToStartFudgeRoom to SourceBufferStream (Closed)

Created:
8 years, 4 months ago by vrk (LEFT CHROMIUM)
Modified:
8 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Add kSeekToStartFudgeRoom to SourceBufferStream Consider the beginning of the buffered region to be the beginning of the stream only if it is within the kSeekToStartFudgeFroom. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150181

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : respond to CR #

Patch Set 4 : rebase ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -10 lines) Patch
M media/filters/chunk_demuxer_unittest.cc View 1 2 3 4 chunks +61 lines, -4 lines 0 comments Download
M media/filters/source_buffer_stream.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/filters/source_buffer_stream.cc View 3 chunks +14 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
vrk (LEFT CHROMIUM)
There are existing tests in ChunkDemuxer and SourceBufferStream that cover the seek-to-not-quite-the-start case, so I ...
8 years, 4 months ago (2012-08-03 23:52:03 UTC) #1
acolwell GONE FROM CHROMIUM
LGTM https://chromiumcodereview.appspot.com/10832151/diff/2001/media/filters/chunk_demuxer_unittest.cc File media/filters/chunk_demuxer_unittest.cc (right): https://chromiumcodereview.appspot.com/10832151/diff/2001/media/filters/chunk_demuxer_unittest.cc#newcode592 media/filters/chunk_demuxer_unittest.cc:592: void ExpectStall(DemuxerStream* stream) { s/ExpectStall/ExpectEndOfStream/ ? since that ...
8 years, 4 months ago (2012-08-04 00:04:51 UTC) #2
vrk (LEFT CHROMIUM)
8 years, 4 months ago (2012-08-06 20:43:42 UTC) #3
https://chromiumcodereview.appspot.com/10832151/diff/2001/media/filters/chunk...
File media/filters/chunk_demuxer_unittest.cc (right):

https://chromiumcodereview.appspot.com/10832151/diff/2001/media/filters/chunk...
media/filters/chunk_demuxer_unittest.cc:592: void ExpectStall(DemuxerStream*
stream) {
On 2012/08/04 00:04:51, acolwell wrote:
> s/ExpectStall/ExpectEndOfStream/ ? since that looks like what is happening
here.

Done.

Powered by Google App Engine
This is Rietveld 408576698