Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 10832127: Pyauto perf test testNewTabDocs now waits for a different page element. (Closed)

Created:
8 years, 4 months ago by dennis_jeffrey
Modified:
8 years, 4 months ago
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1, Nirnimesh, fdeng1
Visibility:
Public.

Description

Pyauto perf test testNewTabDocs now waits for a different page element. testNewTabDocs loads Google Docs and then waits until an expected substring appears on the page before continuing. Previously, the test waited for a string that only appears when viewing the "my drive" folder, because it was assumed that we'd always see that folder when opening google docs. However, sometimes the "shared with me" folder appears on page load. This appears to be because google docs opens the last folder opened by the account. Since we have another perf test that clicks on the "shared with me" folder, then the current test will sometimes fail to realize the page loaded, since an unexpected screen is displayed after page load. The fix is to have this test wait for a different substring on the page, which appears regardless of which folder shows up when loading google docs. BUG=None TEST=Verified the test runs for 10 iterations whereas previously it failed after only 1 or 2 iterations. NOTRY=true Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149777

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/test/functional/perf.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
dennis_jeffrey
big description for a small change
8 years, 4 months ago (2012-08-03 01:11:35 UTC) #1
Nirnimesh
LGTM
8 years, 4 months ago (2012-08-03 01:21:44 UTC) #2
asharif1
On 2012/08/03 01:21:44, Nirnimesh wrote: > LGTM lgtm. Thanks for this fix.
8 years, 4 months ago (2012-08-03 01:28:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dennisjeffrey@chromium.org/10832127/1
8 years, 4 months ago (2012-08-03 01:30:02 UTC) #4
commit-bot: I haz the power
Change committed as 149777
8 years, 4 months ago (2012-08-03 01:55:47 UTC) #5
asharif1
On 2012/08/03 01:55:47, I haz the power (commit-bot) wrote: > Change committed as 149777 The ...
8 years, 4 months ago (2012-08-03 17:51:40 UTC) #6
dennisjeffrey
8 years, 4 months ago (2012-08-03 17:54:23 UTC) #7
Yes.  That should be fixed soon once we convert the test to use a recording
of the site (with Web Page Replay), rather than connecting to the live site
every time.

-Dennis


On Fri, Aug 3, 2012 at 10:51 AM, <asharif@chromium.org> wrote:

> On 2012/08/03 01:55:47, I haz the power (commit-bot) wrote:
>
>> Change committed as 149777
>>
>
> The test will show some variability since the pages loaded may be different
> every time.
>
>
https://chromiumcodereview.**appspot.com/10832127/<https://chromiumcodereview...
>

Powered by Google App Engine
This is Rietveld 408576698