Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 10832126: Store pointer instead of reference to LocalVariable in ast and flow graph. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intermediate_language_ia32.cc
===================================================================
--- runtime/vm/intermediate_language_ia32.cc (revision 10207)
+++ runtime/vm/intermediate_language_ia32.cc (working copy)
@@ -128,7 +128,7 @@
void LoadLocalComp::EmitNativeCode(FlowGraphCompiler* compiler) {
Register result = locs()->out().reg();
- __ movl(result, Address(EBP, local().index() * kWordSize));
+ __ movl(result, Address(EBP, local()->index() * kWordSize));
}
@@ -143,7 +143,7 @@
Register value = locs()->in(0).reg();
Register result = locs()->out().reg();
ASSERT(result == value); // Assert that register assignment is correct.
- __ movl(Address(EBP, local().index() * kWordSize), value);
+ __ movl(Address(EBP, local()->index() * kWordSize), value);
}
@@ -1468,11 +1468,11 @@
-locals_space_size + FlowGraphCompiler::kLocalsOffsetFromFP;
__ leal(ESP, Address(EBP, offset_size));
- ASSERT(!exception_var().is_captured());
- ASSERT(!stacktrace_var().is_captured());
- __ movl(Address(EBP, exception_var().index() * kWordSize),
+ ASSERT(!exception_var()->is_captured());
+ ASSERT(!stacktrace_var()->is_captured());
+ __ movl(Address(EBP, exception_var()->index() * kWordSize),
kExceptionObjectReg);
- __ movl(Address(EBP, stacktrace_var().index() * kWordSize),
+ __ movl(Address(EBP, stacktrace_var()->index() * kWordSize),
kStackTraceObjectReg);
}

Powered by Google App Engine
This is Rietveld 408576698