Store pointer instead of reference to LocalVariable in ast and flow graph.

runtime/vm/scopes.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/scopes.h"
 
 #include "vm/ast.h"
 #include "vm/bit_vector.h"
 #include "vm/object.h"
 #include "vm/parser.h"
@@ skipping 507 matching lines @@
   context_scope.SetIsFinalAt(0, true);
   const AbstractType& type = AbstractType::Handle(func.ParameterTypeAt(0));
   context_scope.SetTypeAt(0, type);
   context_scope.SetContextIndexAt(0, 0);
   context_scope.SetContextLevelAt(0, 0);
   ASSERT(context_scope.num_variables() == kNumCapturedVars);  // Verify count.
   return context_scope.raw();
 }
 
 
-bool LocalVariable::Equals(const LocalVariable& other) const {
-  if (HasIndex() && other.HasIndex() && (index() == other.index())) {
-    if (is_captured() == other.is_captured()) {
+bool LocalVariable::Equals(const LocalVariable* other) const {
+  if (HasIndex() && other->HasIndex() && (index() == other->index())) {
+    if (is_captured() == other->is_captured()) {
       if (!is_captured()) {
         return true;
       }
-      if (owner()->context_level() == other.owner()->context_level()) {
+      if (owner()->context_level() == other->owner()->context_level()) {
         return true;
       }
     }
   }
   return false;
 }
 
 
 int LocalVariable::BitIndexIn(intptr_t fixed_parameter_count) const {
   ASSERT(!is_captured());
   // Parameters have positive indexes with the lowest index being 2.  Locals
   // and copied parameters have negative indexes with the lowest (closest to
   // zero) index being ParsedFunction::kFirstLocalSlotIndex.
   if (index() > 0) {
     // Shift non-negative indexes so that the lowest one is 0.
     return (fixed_parameter_count - 1) - (index() - 2);
   } else {
     // Shift negative indexes so that the lowest one is 0 (they are still
     // non-positive).
     return fixed_parameter_count -
         (index() - ParsedFunction::kFirstLocalSlotIndex);
   }
 }
 
 
 }  // namespace dart