Issue 10832123: Coverity: Fix a sizeof mismatch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10832123: Coverity: Fix a sizeof mismatch. (Closed)

Created:
8 years, 4 months ago by James Hawkins

Modified:
8 years, 4 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Coverity: Fix a sizeof mismatch. It appears the sizeof change was to make the code more future proof: sizeof(float) -> sizeof(audio_data[0]) However, audio_data[0] is a float*, not the intended float. Adding the deref to fix this. CID_COUNT=1 CID=104561 BUG=none R=scherkus Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=149770

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/media/render_audiosourceprovider.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/10832123/1

8 years, 4 months ago (2012-08-02 23:39:35 UTC) #3

Change committed as 149770

Expand Messages | Collapse Messages