Attach the native entry struct to the ArchiveEntry object.

utils/archive/messaging.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef DART_ARCHIVE_MESSAGING_H_
 #define DART_ARCHIVE_MESSAGING_H_
 
 #include "dart_archive.h"
 
 /**
@@ skipping 33 matching lines @@
 /**
  * Checks [error], the return code of a libarchive call for error conditions,
  * and sends an appropriate error response if any are detected.
  * 
  * Returns `true` if an error is detected and the containing function should
  * short-circuit.
  */
 bool checkError(Dart_Port p, struct archive* a, int result);
 
 /**
+ * Sends an error response if [pointer] is invalid. [name] is the name of the
+ * object being allocated, for error reporting.
+ * 
+ * Returns `true` if an error is detected and the containing function should

[Bob Nystrom, 2012/08/02 18:18:25]

Returning "true" on failure feels backwards to me. How about something like
"validatePointer" which returns "false" on error?

[nweiz, 2012/08/02 21:32:27]

Every single time you want to call this and related methods, it will be in the
context of "if (check*(...)) return". While I agree that in a stand-alone API,
returning false for errors makes more sense, in this case I don't think it's
worth adding a bunch of extra negation tokens for no real gain.

+ * short-circuit.
+ */
+bool checkPointerError(Dart_Port p, void* pointer, char* name);
+
+/**
  * Like [checkError], but sends a success message with no attached data if no
  * error is detected. No further responses should be sent after calling this.
  */
 void checkResult(Dart_Port p, struct archive* a, int result);
 
 /**
+ * Like [checkPointerError], but sends a success message with the pointer as a
+ * Dart integer if no error is detected. No further responses should be sent
+ * after calling this.
+ */
+void checkPointerResult(Dart_Port p, void* pointer, char* name);
+
+/**
  * Checks that [object] is of the expected type [type]. If not, sends an
  * appropriate error response.
  *
  * Returns `true` if a type error is detected and the containing function should
  * short-circuit.
  */
 bool checkType(Dart_Port p, Dart_CObject* object, enum Type type);
 
 /**
  * Gets the [i]th argument from [request], which should be the Dart object
@@ skipping 14 matching lines @@
  * of the argument.
  */
 Dart_CObject* getIntArgument(Dart_Port p, Dart_CObject* request, int i);
 
 /**
  * Gets the integer value of [object], which should be an `int32` or an `int64`.
  * Note that this does not validate the type of its argument.
  */
 int64_t getInteger(Dart_CObject* object);
 
+/**
+ * Like [getArgument], but also ensures that the argument is a string or null.
+ * [getNullableString] should be used to extract the actual value of the
+ * argument.
+ */
+Dart_CObject* getNullableStringArgument(Dart_Port p, Dart_CObject* request,
+    int i);
+
+/**
+ * Gets the string value of [object] or `NULL` if it's null. Note that this does
+ * not validate the type of its argument.
+ */
+char* getNullableString(Dart_CObject* object);
+
 /** Declares a null [Dart_CObject] named [name]. */
 #define DART_NULL(name) \
   Dart_CObject name;    \
   name.type = kNull;
 
 /**
  * Declares a [Dart_CObject] bool named [name] with value [val].
  *
  * [val] should be a C boolean.
  */
@@ skipping 40 matching lines @@
 #define DART_STRING(name, val)  \
   Dart_CObject name;            \
   if (val == NULL) {            \
     name.type = kNull;          \
   } else {                      \
     name.type = kString;        \
     name.value.as_string = val; \
   }
 
 #endif  // DART_ARCHIVE_MESSAGING_H_