Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(893)

Issue 10832113: Prevent CacheStats from DCHECKing when debugging. (Closed)

Created:
8 years, 4 months ago by mmenke
Modified:
8 years, 4 months ago
Reviewers:
tburkard
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Prevent CacheStats from DCHECKing when debugging. R=tburkard@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150407

Patch Set 1 #

Patch Set 2 : Clean up as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M chrome/browser/net/cache_stats.cc View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mmenke
8 years, 4 months ago (2012-08-02 15:21:11 UTC) #1
mmenke
Timo: Ping
8 years, 4 months ago (2012-08-06 15:27:44 UTC) #2
tburkard
lgtm
8 years, 4 months ago (2012-08-06 17:23:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10832113/1002
8 years, 4 months ago (2012-08-06 17:24:38 UTC) #4
commit-bot: I haz the power
Try job failure for 10832113-1002 (retry) on win_rel for step "compile" (clobber build). It's a ...
8 years, 4 months ago (2012-08-06 17:44:56 UTC) #5
mmenke
Looks like windows bots are borked. I'll land it manually once it passes on the ...
8 years, 4 months ago (2012-08-06 17:46:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmenke@chromium.org/10832113/1002
8 years, 4 months ago (2012-08-07 18:44:50 UTC) #7
commit-bot: I haz the power
8 years, 4 months ago (2012-08-07 21:12:57 UTC) #8
Change committed as 150407

Powered by Google App Engine
This is Rietveld 408576698