Simplify devtools code on android and enable devtools for android content_shell.

content/browser/debugger/devtools_http_handler_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/debugger/devtools_http_handler_impl.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 100 matching lines @@
   }
 
  private:
   virtual void FrameNavigating(const std::string& url) {}
   net::HttpServer* server_;
   int connection_id_;
 };
 
 }  // namespace
 
+#if defined(OS_ANDROID)
+// static
+bool DevToolsHttpHandler::IsUserAllowedToConnect(uid_t uid, gid_t gid) {

[pfeldman, 2012/08/02 17:05:50]

I don't think this code belongs here. It looks like a random Android-specific
function to me.

[Satish, 2012/08/02 17:17:53]

This function is specific to the devtools feature, deciding which specific
process on the device to allow connect to devtools. It is android specific hence
the ifdef, but if it is moved elsewhere it will still be used only for the
purpose of devtools http handler and not something else. So this seems class
seems like the appropriate place, similar to how we have
GetFrontendResourceIds() below which is devtools specific but just iterates over
resources ids.

[pfeldman, 2012/08/02 17:37:53]

The code below does not seem to be related to devtools and/or debugging. Placing
it in a separate header or in existing reachable header and giving it a proper
name (CanAccessProcess or something) would be more natural.  Android (vertical
feature) needs it, DevTools (horizontal feature) does not, hence it belongs to
the file matching the ".*android.*" pattern. Does it make sense?

[Satish, 2012/08/06 10:21:41]

Done.

+  struct passwd* creds = getpwuid(uid);
+  if (!creds || !creds->pw_name) {
+    LOG(WARNING) << "DevToolsHttpHandler: can't obtain creds for uid " << uid;
+    return false;
+  }
+  if (gid == uid &&
+      (strcmp("root", creds->pw_name) == 0 ||
+       strcmp("shell", creds->pw_name) == 0)) {
+    return true;
+  }
+  LOG(WARNING) << "DevToolsHttpHandler: connection attempt from "
+               << creds->pw_name;
+  return false;
+}
+#endif
+
 // static
 int DevToolsHttpHandler::GetFrontendResourceId(const std::string& name) {
   for (size_t i = 0; i < kDevtoolsResourcesSize; ++i) {
     if (name == kDevtoolsResources[i].name)
       return kDevtoolsResources[i].value;
   }
   return -1;
 }
 
 // static
@@ skipping 487 matching lines @@
 void DevToolsHttpHandlerImpl::AcceptWebSocket(
     int connection_id,
     const net::HttpServerRequestInfo& request) {
   BrowserThread::PostTask(
       BrowserThread::IO, FROM_HERE,
       base::Bind(&net::HttpServer::AcceptWebSocket, server_.get(),
                  connection_id, request));
 }
 
 }  // namespace content